search

ucsb-cs156-s24 / proj-courses-s24-4pm-2

https://ucsb-cs156-s24.github.io/proj-courses-s24-4pm-2/
0 stars 0 forks source link

Evan course history search output correction #19

Closed evanja57 closed 1 month ago

evanja57 commented 1 month ago

In this pull request, I have updated the CourseOverTimeIndexPage to pass a version of the courseJSON that is sorted by decreasing quarter to the SectionsOverTimeTable, thus enabling it to render in the proper order when called.

Here is the observed bug for a search on our team's dokku server: image

And here is the fixed version on my dev development: image

Originally, it goes oldest to newest, (winter first, then spring), but I have changed it to be the opposite.

Additionally, I had to fix the tests for CourseOverTimeIndexPage in order to pass and kill all mutations, and in doing so I added an extra sectionFixture with entries with different quarters so that I could verify that the sorting by quarter was working properly.

Also, I noticed that also for the building search and the instructor search, the results are displayed with oldest quarter first. For all 3 searches, I believe this is because of the order in which the API returns data, which is why I chose to sort the data when sending it to the SectionsOverTimeTable in the CourseOverTimeIndexPage.

Dev Dokku Link: https://proj-courses-evanja57-dev.dokku-02.cs.ucsb.edu/ Closes #11

evanja57 commented 1 month ago

Just added my dokku dev link to the PR