search

ucsb-cs156-s24 / proj-organic-s24-5pm-3

https://ucsb-cs156-s24.github.io/proj-organic-s24-5pm-3/
0 stars 1 forks source link

[feat] Swagger option on Navbar #20

Closed andrew-kwon1 closed 4 months ago

andrew-kwon1 commented 4 months ago

User Story: As a developer I can easily turn on the swagger option on the app navbar for any deployment through defining an environment variable SHOW_SWAGGER_UI_LINK so that it is easy to access swagger when I need it, but I can easily turn it off when I don't.

Allows developer to set a variable called SHOW_SWAGGER_UI_LINK to true or false in their config variables. When set to true: image

When set to false: image

Closes #6

sanilkatula commented 4 months ago

Could you specify in detail what exactly you changed? And why was it necessary?

Make sure your PR is well constructed, with details of what you accomplished and what it might help to accomplish.

For example:- if you are working on the backend and made api's. a storybook and link to swagger would be very helpful

and if you are working frontend, screenshots of how it looks and a deployment link would make the process of merging smoother.

If you have any questions and want to see some idle PR feel free to ask.

andrew-kwon1 commented 4 months ago

In initial checks for the pull request, 12-backend-jacoco and 13-backend-inremental-pitest had this error: Error: JobsControllerTests.admin_can_launch_test_job_that_fails:221 » ConditionTimeout even though on local, all tests passed. I rebuilt the jobs a few times and eventually passed, not sure what the issue was.

sanilkatula commented 4 months ago

LGTM

sanilkatula commented 4 months ago

Ask someone from your team to review the PR than we can proceed with the merge.

yuxiaolejs commented 4 months ago

Ask someone from your team to review the PR than we can proceed with the merge.

Thanks!