search

ucsb-cs156-s24 / proj-organic-s24-5pm-3

https://ucsb-cs156-s24.github.io/proj-organic-s24-5pm-3/
0 stars 1 forks source link

added school edit pages, utils, tests, stories #36

Closed 30912hyl closed 3 months ago

30912hyl commented 3 months ago

Worked on Issue #33, which I split from EPIC issue #4, which sets up the frontend for School CRUD

https://organic-30912hyl.dokku-11.cs.ucsb.edu/

Since school Create has not been implemented yet, in order to test this please first manually create a school entry with https://organic-30912hyl.dokku-11.cs.ucsb.edu/swagger-ui/index.html#/

Closes #33

30912hyl commented 3 months ago

nevermind, tested the edit button and it seems to not be linked. please don't review for now!

30912hyl commented 3 months ago

ok, seems to be fixed, can review now!

30912hyl commented 3 months ago

Code looks good.. but when I tried this on the dokku deployment, I was unable to create a school. Therefore I was unable to test editing a school, which seems to be the main thing in this PR.

I wonder if your dokku deployment is out of date?

Or if create is in a different PR that needs to come before this one for testing purposes?

Oh, sorry yes that is the case! Since this requires a school to have been created already, for testing purposes this PR must come after EPIC Issue #4 F1.1. Another option that I tried and confirmed was to test on localhost, creating a school using Swagger and attempting to use the edit button there. It may also be possible to edit the initial database for Dokku, however for simplicity's sake, should I leave this PR as it is with just localhost screenshots, and create a new PR later for the dev deployment once EPIC Issue #4 F1.1 is done?

30912hyl commented 3 months ago

Ok, I updated the PR description so that anyone can go to Swagger first and create a school entry. That way there is an entry present to test "edit button"

pconrad commented 3 months ago

Make sure that the backend api in your branch matches this:

  const deleteMutation = useBackendMutation(
         cellToAxiosParamsDelete,
         { onSuccess: onDeleteSuccess },
         ["/api/schools/all"]
);

And make sure that you've tested delete.