search

ucsb-cs156-s24 / proj-organic-s24-5pm-3

https://ucsb-cs156-s24.github.io/proj-organic-s24-5pm-3/
0 stars 1 forks source link

[merge] Changing school selection to drop down #50

Closed yuxiaolejs closed 1 month ago

yuxiaolejs commented 1 month ago

In this PR, I changed the school selection in course create/edit pages to use drop down.

Dokku dev deployment available here: https://organic-yuxiaolejs-gha.dokku-11.cs.ucsb.edu/

It looks like:

image

Story here: https://ucsb-cs156-s24.github.io/proj-organic-s24-5pm-3/prs/50/storybook/?path=/story/components-courses-coursesform--create (Not working since no data provided by backend)

Closes #5

sanilkatula commented 1 month ago

Does this PR only have a story book? Change the heading of the PR accordingly. you can feed the data through Swagger and test if the frontend is working.

sanilkatula commented 1 month ago
Screenshot 2024-05-30 at 5 05 02 PM

it does not work.

yuxiaolejs commented 1 month ago

Does this PR only have a story book? Change the heading of the PR accordingly. you can feed the data through Swagger and test if the frontend is working.

Oh, I mean the storybook is not working... The stage deployment is working now and I am feeding data so that you can test it alive.

yuxiaolejs commented 1 month ago

@pconrad Sorry for lying to you... It's all fixed now! I have fed some data by directing inserting into the DB so that you can test it.

pconrad commented 1 month ago

@pconrad Sorry for lying to you... It's all fixed now! I have fed some data by directing inserting into the DB so that you can test it.

You didn't exactly "lie" ... maybe at most you were "careless with the truth". I apologize for using that word.

The point is: if your PR description says that the deployment is for that branch, you need to freeze that deployment until the PR is merged.