search

ucsb-cs156-s24 / proj-organic-s24-5pm-3

https://ucsb-cs156-s24.github.io/proj-organic-s24-5pm-3/
0 stars 1 forks source link

Linked API to Create School button, added tests and Storybook #57

Closed sherpatran closed 1 month ago

sherpatran commented 1 month ago

Made sure that the CreateSchool button is working. Connected it to the proper Schools POST api and added the tests/storybook for that feature.

The parameter termRegex had to be encoded because of the disallowed characters "[" and "\". This allows termRegex to be passed through the frontend without any issues. Then, to get the accurate value passed into the backend, termRegex is decoded in the SchoolController.

https://organic-sherpatran-dev.dokku-11.cs.ucsb.edu/

Closes #7 and closes #8.

sherpatran commented 1 month ago

Why are there changes to backend files in this PR?

It makes this harder to review. Including changes to files that are unrelated to the PR is frowned upon in professional SW dev.

This page explains how you can easily remove the changes to some files from your PR:

https://ucsb-cs156.github.io/topics/pull_requests/pull_requests_simplifying.html

The changes to the backend were necessary because of the encoding issues with TermRegex. I also believe that I removed the changes to the interceptor. Should I still break up this PR into the changes to frontend and backend?

sherpatran commented 1 month ago

Created new PR with cleaner commits.