[x] The Rider Application Form had two fields: Application Id and Applicant Id. This implementation was wrong and should only have one field for ID which is the rider application ID. This ID can be found in the Rider Application Entities file.
[x] The email field the in the form should be auto populated with the current user's email. This was not the case prior.
[x] Must fix the date update, applied, and cancelled fields to be disabled for all users. Cancelled date field will only show if the application was cancelled.
[x] Notes can only be edited by an admin user. Notes should only be displayed if there are notes made by the admin.
[x] Current tests do not test form well (at all). Add some more tests.
In this PR, I fixed the Rider Application Form to match the requirements from the EPIC.
I also added code that fixed the storybook for the form. Prior, storybooks did not display the different states the form can be in. I added a storybook for when a user is creating a new application, when a user is editing their application, and one for an admin editing an application.
For the RiderApplicationForm itself, I added the changes that were specified under the Task checklist. More importantly, I added code so that the form can access the currentUser object and check if the user was regular user or admin. This was important for implementing the requirements listed in the issue I linked to below. Having the currentUser object was also important for autofilling the email field in the form.
shamitagurusu
commented
6 months ago
Task
In this PR, I fixed the Rider Application Form to match the requirements from the EPIC.
I also added code that fixed the storybook for the form. Prior, storybooks did not display the different states the form can be in. I added a storybook for when a user is creating a new application, when a user is editing their application, and one for an admin editing an application.
For the RiderApplicationForm itself, I added the changes that were specified under the Task checklist. More importantly, I added code so that the form can access the currentUser object and check if the user was regular user or admin. This was important for implementing the requirements listed in the issue I linked to below. Having the currentUser object was also important for autofilling the email field in the form.
Closes #22