In this PR, we are fixing an error when another team member reverted a line of code to an older version.
var tableStyle = {
"background": "white",
"display": "table" ,
//display used to be set to "block" and was changed to table, but someone else changed it back to block
"maxWidth": "100%" ,
"margin": "0 auto" ,
"overflowX": "auto" ,
"whiteSpace": "nowrap"
};
Feedback Request (Optional)
Please give suggestions on the following:
On making sure changes made after my initial PR are still safe.
Future Possibilities (Optional)
Some possible points could be:
This might cause future errors if the later commits need that line to be the old version.
Validation (Optional)
Download this branch.
Run the project.
Go to this page.
Test this function.
Tests
[ ] Backend Unit tests (mvn test) pass
[ ] Backend Test coverage (mvn test jacoco:report) 100%
[ ] Backend Mutation tests (mvn test pitest:mutationCoverage) 100%
[ ] Frontend Unit tests (npm test) pass
[ ] Frontend Test coverage (npm run coverage) 100%
aardvarkzone
commented
7 months ago
Overview
In this PR, we are fixing an error when another team member reverted a line of code to an older version.
var tableStyle = { "background": "white", "display": "table" , //display used to be set to "block" and was changed to table, but someone else changed it back to block "maxWidth": "100%" , "margin": "0 auto" , "overflowX": "auto" , "whiteSpace": "nowrap" };
Feedback Request (Optional)
Please give suggestions on the following:
Future Possibilities (Optional)
Some possible points could be:
Validation (Optional)
Tests
mvn test) passmvn test jacoco:report) 100%mvn test pitest:mutationCoverage) 100%npm test) passnpm run coverage) 100%npx stryker run) 100%npx eslint --fix src)Linked Issues
Closes #2