search

ucsb-cs56-projects / cs56-android-smoke-signals

-
GNU General Public License v3.0
1 stars 7 forks source link

Fix //Ring #14

Closed thatonesimon closed 8 years ago

thatonesimon commented 8 years ago

If the phone is on vibrate or mute, the ring method may not work, so force it to ring even if the phone is on mute or vibrate.

thatonesimon commented 8 years ago

This was fixed in pull request #15, wondering if we can get points for fixing this small bug.

jimmylle commented 8 years ago

@thatonesimon So i'm not sure if the ring method is supposed to ring when the phone is on vibrate/mute because the user probably put it on vibrate/mute so that it won't give them notifications and stuff and making the ring method bypass that might not be what they want. Instead you could have a new command or add additional argument to the ring method like "//Ring force" or something so that it force rings the phone because maybe the user can't find their phone and needs it to ring regardless of vibrate/mute. So if you go that route edit this issue to make it clearer about what its changing.

jimmylle commented 8 years ago

F16 OK (100 pts)

jimmylle commented 8 years ago

Fixed in this pull request.