Closed ericpalyan closed 10 years ago
ericpalyan
commented
10 years ago @andrewberls, I tagged jstaal as my moderator because his name was in the README, "W14 ready! (Jakob Staahl)", and in the title, " (jstaahl) Blackjack game", but after wondering why I wasn't getting feedback I noticed that you are the moderator for this repo.
andrewberls
commented
10 years ago Hey Eric, sorry for the delay in giving you feedback - your notification went right past me somehow. Overall, this is looking really good! The game plays really well - the card images are a great touch. The code looks good as well - things are pretty well commented throughout, and it's always nice to see huge swaths of doc code being deleted. I think my only suggestions for improvement revolve around opportunities for removing duplicated code by extracting some common patterns into methods, or eliminating that huge switch statement with some file renaming!
bzimm
commented
10 years ago I am doing a code review.
githubID: bzimm moderator: Brynn @bkiefer13
Issues that needed resolving before moving on: Cleaning up the code and adding comments There was very little comments and the code was in big chunks. Made it difficult to understand what was being done. Had to go through and add comments, format it better, move some things around for efficiency, etc. ~request 100
Cleaning up/Enhancing the GUI The window frames would pop up off screen and the widgets were not aligned. Fixed those and also formatted the player panels to make them "layered" instead of all the text being on one line (the JLabels that display player information). ~request 100
Main Issues Issue #8 - Currency Had to work around a few things and figure out how the code was executing and in what order. I also had to make multiple methods to keep track of changes as well as keep the labels updated etc. It took some time to implement so I did not have time to allow the user to change the bet value after each hand but that can be easily added the next time. ~request: 200
Issue #9 - Double Down It only allows the player to double down at the beginning of their hand. Once they hit the option disables/"goes away". Doubling down deducts the bet amount from the player's money on hand and draws one card. After that the player can't hit, it goes on to the next player at the table (or the dealer). ~request: 150
Other Issues/Enhancements Rules Frame Added a rules window explaining how the game is played along with winning/losing conditions, etc for those who are not familiar with blackjack or need a reminder. ~request: 75
5 Card Charlie This is another rule in blackjack (or in a form of one). Having 5 cards without busting is another condition to win. Blackjack(21) > 5 card charlie. ~request: 75
~request total: 700