search

ucsb-cs56-projects / cs56-games-fish-animation

-
1 stars 11 forks source link

different characters have different features #93

Closed 9728627 closed 6 years ago

9728627 commented 6 years ago

whale and shark have differnt MAXhealth whale: 100 shark: 50

whenever whale eat fish, it will add less health than shark. However, evenever whale accesses the jellyfish, it will loss more health than shark.

xavierholt commented 6 years ago

This seems like a hacky way to implement https://github.com/UCSB-CS56-Projects/cs56-games-fish-animation/issues/65. I'll give you some points for this, but not all. A better, cleaner approach would be to implement a Character base class with Shark and Whale subclasses.

9728627 commented 6 years ago

pushed

9728627 commented 6 years ago

Hey, Kevin. Can you help me check this PR? Is it good to go? Thanks a lot.