search

ucsb-cs56-projects / cs56-utilities-password-generator

-
1 stars 5 forks source link

implement .equals method, along with test cases #37

Closed pconrad closed 8 years ago

pconrad commented 8 years ago

The junit test cases are all commented out.

That's a problem. We can't do ANYTHING reasonable on this repo until the test cases are restored.

The place to start is with the very first test case: namely:

https://github.com/UCSB-CS56-Projects/cs56-utilities-password-generator/blob/master/src/PasswordTest.java#L16

That one looks like this:

   @Test public void testNoArgConstructor(){
    Password p1 = new Password();
    Password p2 = new Password();
    assertEquals(p1, p2);
    }

And it doesn't pass, because there is no sane .equals method for this class.

So implementing that is the first order of business.

Do that, and then one at a time, get the other test cases to pass. Restoring the existing test cases so that they pass is worth 250 points.

And, I strongly, strongly, strongly encourage you to focus on that one first.

Regards, Phill Conrad

pconrad commented 8 years ago

@EdieS and @jhpenger please work on this one!