search

ucsb-cs56-projects / cs56-utilities-password-generator

-
1 stars 5 forks source link

Finished Project #1 #7

Closed 108498asdf closed 10 years ago

108498asdf commented 10 years ago

@jcneally I finished Project #1, issue #3,4,5. For issue #5, there are no error checking implemented(because it wasn't assigned), so please don't input special characters for min/max or have a max that is less than min.

~requested: 500

bkiefer13 commented 10 years ago

PROJ1 MOD REVIEW DONE

kjorg50 commented 10 years ago

Good job deleting the unnecessary stuff from the build.xml. However, you didn't refactor some of the targets to use the new classpath format -- see step four of these guidelines. You can replace code blocks like this:

<classpath>
    <pathelement location="build"/>
    <pathelement location="/cs/faculty/pconrad/public_html/cs56/lib/junit-4.8.2.jar"/>
</classpath>

with just this one line

<classpath refid="project.class.path" />