search

ucsb-cs56-projects / cs56-utilities-todo

-
0 stars 6 forks source link

W15-lab06 added md file #21

Closed hannavigil closed 9 years ago

PazZaitGivon commented 9 years ago

Hey, please make a new pull request to the appropriate branch asap remember you need to pull to the hannavigil branch

PazZaitGivon commented 9 years ago

also there is a bug with the implementation of edit. It will not receive full points and you are 75 points off the 500 to get full credit. To make my life easier when you repull please link to the issues you have completed or at least give me their names. If you can get it done by tommorrow I probably will still suggest adding the points

hannavigil commented 9 years ago

Hey Paz, I can't recreate the edit bug. It seems to work fine through my CSIL account. Could you let me know how exactly you found the bug? Also, I think we should be above the 500 pt mark. We did the deletion bug (100), javadoc (25), delete all completed (100), sorting (125), edit (?), and saving and loading from a file (200). I don't think you saw the last one though, or it didn't work? I'll do a pull request with links as soon as we figure out the edit issue. Thanks, Hanna

On Sat, Mar 14, 2015 at 10:59 AM, Paz Zait-Givon notifications@github.com wrote:

also there is a bug with the implementation of edit. It will not receive full points and you are 75 points off the 500 to get full credit. To make my life easier when you repull please link to the issues you have completed or at least give me their names

— Reply to this email directly or view it on GitHub https://github.com/UCSB-CS56-Projects/cs56-utilities-todo/pull/21#issuecomment-80644961 .

PazZaitGivon commented 9 years ago

ahh did not see the save and load from file. the bug ihappens I think if you add a task after editing?

hannavigil commented 9 years ago

Hey Paz, Fixed the bug and made a new pull request. Hope I did it correctly this time. Let me know if I did not. Thanks, Hanna

On Sat, Mar 14, 2015 at 12:03 PM, Paz Zait-Givon notifications@github.com wrote:

ahh did not see the save and load from file. the bug ihappens I think if you add a task after editing?

— Reply to this email directly or view it on GitHub https://github.com/UCSB-CS56-Projects/cs56-utilities-todo/pull/21#issuecomment-80674303 .