Make GitHub login actually work consistently

ucsb-cs56-w20 / mapache-search

https://mapache-search-qa.herokuapp.com/

2 stars 3 forks source link

Make GitHub login actually work consistently #218

Closed DubiousLatchkey closed 4 years ago

DubiousLatchkey commented 4 years ago

Currently, there are still fragments from differentiating Google and Github Oauth that lead to the membershipService not working if the user has an attribute "email". Change the GithubOrgMembershipService so that it properly authenticates all users and removes the holdover code from Google OAuth.

DubiousLatchkey commented 4 years ago

[x] Github users with the "email" attribute are still counted as members
[x] Admin users are counted as admins