search

ucsb-cs56-w20 / ucsb-courses-search

Spring Boot App to show similar information to that found at UCSB Curriculum Search page
https://ucsb-courses-search.herokuapp.com
2 stars 5 forks source link

T 7pm d details button per course #200

Closed jackkilgore closed 4 years ago

jackkilgore commented 4 years ago
pconrad commented 4 years ago

@jackkilgore It is helpful if you can link to the issue from the PR so that we can check the acceptance criteria

pconrad commented 4 years ago

Some comments that were also put on the team's slack:

The byDept search is intended to replace the old home page search, which should go away.

The only reasons it hasn't gone away yet is that it is the only place that had the buttons for the personal schedule.

But, we really want that view to go away completely, and be replaced by the byDept view.

That view may not be perfect, but it's in much better shape than the old home page view.

Your PR eliminates the good new view, and makes the old bad view the standard.

Could you, instead, add your details modal to the new view?

We will separately ask the team working on personal schedule to also move their buttons into the new view.

jackkilgore commented 4 years ago

The issue with an updated acceptance criteria. https://github.com/ucsb-cs56-w20/ucsb-courses-search/issues/142

jackkilgore commented 4 years ago

Current Status: I have cleaned up the look of the NEW result table and have succesfully integrated it, along with the detail buttons for the department course search. PROBLEM: The home page as well as the instructor search page do not display their results. This is due to the new table utilizing the CourseListingRow class for data, while the instructors and home page seem(???) to only have access to the data coming from the Course class.

jackkilgore commented 4 years ago

Ok, I think its done. If someone adds course descriptions into the modal found in templates/fragments/generic_table_results.html, they will be applied to the main search results, the department search results, the instructor multiquarter and generic instructor results. The specific instructor results is an edge case and has been left alone for now. The course search has not been dealt with yet.

Thanks Jack