search

ucsb-eri / surfcam

campus point surfcam
GNU General Public License v3.0
5 stars 1 forks source link

Feature/display-local-time #1

Closed ventura-rivera closed 2 years ago

ventura-rivera commented 2 years ago

This feature adds a timestamp to wavedata.txt and gendata.txt so that viewers can view the local time to better pinpoint parts of the video they are interested in seeing.

ventura-rivera commented 2 years ago

@slapplebags I cannot request a reviewer. Can you please check this out?

slapplebags commented 2 years ago

I'll give it a go in the morning

slapplebags commented 2 years ago

looks good and I appreciate the work but I had a thought. Any reason we wouldn't use the cameras built in timestamp? I can turn that on if that offers the same functionality you're after.

ventura-rivera commented 2 years ago

You know, I thought to myself if this camera has built-in time, and I agree it would be much preferable. I did some digging, and I think I can make that change.

ventura-rivera commented 2 years ago

@slapplebags After some digging, I updated the ffmpeg to use the localtime. Apologies if the command looks off at all (I have never used ffmpeg before). If it does, please suggest where it should be altered.

Also, if there is something wrong with the ffmpeg localtime, and you want to revert back to the timestamp script, just let me know.

slapplebags commented 2 years ago

I've enabled the camera's built in timestamp feature and set it up in the upper right of the image. A lot less overhead for us then adding it to the wave data scraper or the ffmpeg command. Let me know if that is sufficient, if not we can look at merging this in.

ventura-rivera commented 2 years ago

oh heck yeah!! It looks great! Thanks for adding that in! I will close this PR.

In the future, if there is anything you'd like some assistance with, I'd be happy to lend a hand 🙂

slapplebags commented 2 years ago

Most common request so far is to convert the metric units to imperial, could have a go at that if you're looking for a quick side project.

ventura-rivera commented 2 years ago

sounds good, I'll give it a go later on!

slapplebags commented 2 years ago

Also if you have any interest i want to build my own wave data buoy a little closer in to shore. I've found an open source project that put some ground work in but theres lots of room for improvement.

ventura-rivera commented 2 years ago

Yeah definitely interested! Do you have anything up on Github yet? And where can I find the open source project?

slapplebags commented 2 years ago

nothing in github yet but i'll setup a repo and add you. Project i found is here: https://github.com/wattnotions/OpenWave. I've ordered an arduino mkr zero and the same BNO055 IMU he uses, both of which should be here soon. I'm planning on using LoRA for comms.

ventura-rivera commented 2 years ago

I don't have a ton of experience with embedded systems and IoT, although I have worked on arduinos and raspberry pis in the past, and it is an area I am highly interested in learning more about. I'll dig though the repo, and learn more about it!

slapplebags commented 2 years ago

Not a problem, I've got a fair amount of embedded and iot experience, but not so much with imu / the required data processing.

On Fri, Nov 4, 2022, 12:13 Ventura Rivera @.***> wrote:

I don't have a ton of experience with embedded systems and IoT, although I have worked on arduinos and raspberry pis in the past, and it is an area I am highly interested in learning more about. I'll dig though the repo, and learn more about it!

— Reply to this email directly, view it on GitHub https://github.com/ucsb-eri/surfcam/pull/1#issuecomment-1304045153, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB75VVG6NRC53FYQ3MH4D2DWGVN4ZANCNFSM6AAAAAARW23ITQ . You are receiving this because you were assigned.Message ID: @.***>

ventura-rivera commented 2 years ago

Just accepted the invitation to the WaveOSS repo. I'll read more into all of this!