search

ucsb / webguide

Repository for the UCSB WSG Webguide hosted on Github using Jekyll.
https://webguide.ucsb.edu
BSD 3-Clause "New" or "Revised" License
7 stars 7 forks source link

Added note on media queries #341

Closed loganfranken closed 6 years ago

loganfranken commented 6 years ago

Fixes #289

loganfranken commented 6 years ago

Does this look good? Anything I can change/update?

loganfranken commented 6 years ago

Thanks @garster! I made those updates; let me know what you think!

garster commented 6 years ago

Looks good to me! @dsaludares or @BwolfUCSB want to approve?

dsaludares commented 6 years ago

Sorry to be a bother, but I think that the period should be inside the quotation mark of "breakpoints."

@garster You reference a section on https://www.grammarly.com/blog/quotation-marks/, that says:

If they apply to the quoted material, they go within the quotation marks. If they apply to the whole sentence, they go outside it:

Sandy asked them, “Why do you guys always fight?”

Did the dog bark every time he heard Sandy say “I’m bringing dinner”?

Just above the section you reference, it says:

Question marks and exclamation points have their own rules.

I think that the section you cite refers only to question marks and exclamation points. That's why the examples listed show usage with question marks.

At the top of the same page you reference, the fourth bullet says:

Commas and periods always go inside the quotation marks in American English; dashes, colons, and semicolons almost always go outside the quotation marks; question marks and exclamation marks sometimes go inside, sometimes stay outside.

So, I think the period should be inside the quotation mark of "breakpoints."

dsaludares commented 6 years ago

After some discussion with @garster and other grammar-knowledgeable folks, I've learned that both ways (placing the period inside or outside of a quotation mark) are correct, so I will approve the PR. We should just make sure that we keep the usage of quotation marks consistent throughout the guide. Thanks, everyone!