search

ucsb / webguide

Repository for the UCSB WSG Webguide hosted on Github using Jekyll.
https://webguide.ucsb.edu
BSD 3-Clause "New" or "Revised" License
7 stars 7 forks source link

Removed Outer section Element #371

Closed loganfranken closed 5 years ago

loganfranken commented 5 years ago

Fixes #322

tenken commented 5 years ago

Just chiming in this looks good to me Logan!

loganfranken commented 5 years ago

Thanks @tenken!

Does this look good to merge in @BwolfUCSB and @sbbeachvball?

BwolfUCSB commented 5 years ago

Go ahead. :)

On Jul 8, 2019, at 9:56 AM, Logan Franken notifications@github.com wrote:

Fixes #322 https://github.com/ucsb/webguide/issues/322 You can view, comment on, or merge this pull request online at:

https://github.com/ucsb/webguide/pull/371 https://github.com/ucsb/webguide/pull/371 Commit Summary

Swapped section element with a div File Changes

M _layouts/default.html https://github.com/ucsb/webguide/pull/371/files#diff-0 (4) M style/main.scss https://github.com/ucsb/webguide/pull/371/files#diff-1 (2) Patch Links:

https://github.com/ucsb/webguide/pull/371.patch https://github.com/ucsb/webguide/pull/371.patch https://github.com/ucsb/webguide/pull/371.diff https://github.com/ucsb/webguide/pull/371.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ucsb/webguide/pull/371?email_source=notifications&email_token=ADFFMM4XMGEQ7YWXQVJROVDP6NWVNA5CNFSM4H65VSPKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G544SEA, or mute the thread https://github.com/notifications/unsubscribe-auth/ADFFMM5KZRBMQ7L6LJCM6ADP6NWVNANCNFSM4H65VSPA.

Brian Wolf Developer / Designer LSCG Web Design Services UC Santa Barbara

wolf@ucsb.edu +1 805-893-593

loganfranken commented 5 years ago

Thanks @BwolfUCSB!

I actually need one of the co-chairs to merge in the pull request. Let me know if you have any questions!

loganfranken commented 5 years ago

Hey there! Since it has no conflicts, I think someone should be able to just press the button and merge this in, but let me know if you need anything from me!

BwolfUCSB commented 5 years ago

No worries

I will merge it tonight. I am actually off today so I will take a look when I get home tonight

Cheers! B

On Aug 5, 2019, at 8:21 AM, Logan Franken notifications@github.com wrote:

Hey there! Since it has no conflicts, I think someone should be able to just press the button and merge this in, but let me know if you need anything from me!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ucsb/webguide/pull/371?email_source=notifications&email_token=ADFFMM43A7F5R2FKFWD7UNTQDBAQTA5CNFSM4H65VSPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3SE7PY#issuecomment-518279103, or mute the thread https://github.com/notifications/unsubscribe-auth/ADFFMMZRWBA25MLNBOVZ7QTQDBAQTANCNFSM4H65VSPA.

Brian Wolf Developer / Designer LSCG Web Design Services UC Santa Barbara

wolf@ucsb.edu +1 805-893-593