search

ucsc-cgp / dos-dss-lambda

Access HCA DSS using GA4GH DOS
MIT License
0 stars 1 forks source link

Python 3 compatibility (closes #24) #25

Closed natanlao closed 6 years ago

natanlao commented 6 years ago

As we're waiting for a test suite, I independently confirmed that these changes don't break anything. (That said, the _scroll_id and search_after key discrepancy still exists.)

natanlao commented 6 years ago

This PR implements Python 3 compatibility while maintaining Python 2 compatibility.

mjkrause commented 6 years ago

The sentence As we're waiting for a test suite, I independently confirmed that these changes don't break anything. is difficult to comprehend.

I'm not sure what you mean by "waiting for...", and "independent ..." from what, and what changes?

natanlao commented 6 years ago

@mjkrause Apologies, let me clarify: I'm working on introducing a standardized test suite for all of our DOS lambdas (TLP-492). This is the same one I've discussed at stand up.

Since dos-dss-lambda currently lacks tests, I had to manually verify that the lambda worked as intended despite the changes made in this PR.

natanlao commented 6 years ago

Thank you for the review, @mjkrause!