Spacing/sizing - Githubissues

ucsc / twentyeleven-ucsantacruz

Child theme for Twenty Eleven based on colors and typefaces of UCSC official web templates.

0 stars 0 forks source link

Spacing/sizing #5

Closed leslieg closed 10 years ago

leslieg commented 10 years ago

I know this is subjective but to my eye, I think the header area would look better if some spacing/sizing were changed a little. Attached a screenshot that attempts to show you what I mean.

the top white area could be taller like original 2011
both the seal/title and search box need a greater margin. 2011 out of the box lines up the title with the beginning of the navigation. That may not give enough room for longer titles but the left and right margins as is seem too small. I think 2011 gives > margin on left than right.
Looks to me like in 2011, the top padding above the title is just slightly larger than bottom.
The title font could be a little thicker
When the title is two lines, the top alignment of the seal and the search box looks weird. Is there any way these elements could be centered? (second screenshot)

leslieg commented 10 years ago

BTW: I've asked David and Scotty if they agree with this feedback.

knice commented 10 years ago

[x] the top white area could be taller like original 2011
[x] both the seal/title and search box need a greater margin. 2011 out of the box lines up the title with the beginning of the navigation. That may not give enough room for longer titles but the left and right margins as is seem too small. I think 2011 gives > margin on left than right.
[x] Looks to me like in 2011, the top padding above the title is just slightly larger than bottom.
[ ] The title font could be a little thicker (left as is because it is the same weight as WCMS sites, "400")
[x] When the title is two lines, the top alignment of the seal and the search box looks weird. Is there any way these elements could be centered? (second screenshot)

About to commit these changes...

leslieg commented 10 years ago

Thanks. I think that the last one (multi-line title) is still the same as before but it actually looks ok to me now....see: http://sites-dev.ucsc.edu/

knice commented 10 years ago

I dropped the line-height to almost as low as it can go. It was 36px, now it is 31.5 (it is relative, 1.05x the font-size). Dropping it any lower risks some characters touching and/or the text being difficult to read.

leslieg commented 10 years ago

Looks good - closing.