ucsc / ucsc-2022

Official WordPress theme for UC Santa Cruz
6 stars 0 forks source link

Feature/ucsc 95/card patterns #228

Closed Vinsanity closed 1 year ago

Vinsanity commented 1 year ago

What does this do/fix?

Note that this is the initial pass at the cards and card grids. We can easily expand on this and add more options later. For now, these are the most common use cases presented in the designs.

QA

Links to relevant issues

Tests

Does this have tests?

Vinsanity commented 1 year ago

This works well; however, I'm not seeing the new 16:9 image sizes when I add large images to the featured. Maybe it's user error? I can see where they're defined in the code, just not in my build. image-sizes

@Herm71 That image has the issue that many of the images provided in the placeholder content script have. They're not big enough to create all the additional sizes that the Image Sizes implement. I would add the regenerate thumbnails plugin to your local and run that on all images and it will at least give you some of the new image sizes. The better solution will be to upload large completely new images and then you should see all the sizes.

Herm71 commented 1 year ago

@Vinsanity Riiiiiight. My bad. Yep, regenerating thumbnails fixed it!