fix: 🔧 wrap a block level element around the skip link and prepend it to the body

ucsc / ucsc-2022

Official WordPress theme for UC Santa Cruz

6 stars 0 forks source link

fix: 🔧 wrap a block level element around the skip link and prepend it to the body #307

Closed knice closed 3 months ago

knice commented 3 months ago

What does this do/fix?

The skip link was getting flagged for not being block level, and for not being the first child of the body. Both issues are resolved with this change.

QA

Issue #293

Tests

The skip link should appear inside of a div with a role of "navigation," just inside the body element.

Herm71 commented 3 months ago

Looks good. Note: Linking to Service Now issues don't take you to the issue, it just takes you to the homepage of SlugHub.