search

ucsc / wcms-design-templates

Styles and Javascript for official UC Santa Cruz web templates
http://webassets.ucsc.edu
4 stars 3 forks source link

Left nav block - text is wrapping around image #228

Closed leslieg closed 10 years ago

leslieg commented 10 years ago

The text to the right of this image should be below the image and the image should stretch to the full width or close to the full width of the left nav area. http://admissions-dev.ucsc.edu/campus-life/index.html

image

jrosczyk commented 10 years ago

fixed

knice commented 10 years ago

Unfortunately, I had partially published a fix for this yesterday, but still needed to account for "bare" images that could be added to the block via the WYSIWYG editor. I took part of your fix and worked it into https://github.com/ucsc/webtemplates2014/commit/a24707c340c0dc07e044d69e72ac8cc6558c7486

A sample global block is in the department-left-column.hbs file:

2014-08-19-160444

I'm not aware of all of the places on the site that have multiple left nav blocks (maybe ITS?), so someone will need to test this.

jrosczyk commented 10 years ago

I set it up so it would work for all images in the sidebar only, and not just the case that Leslie pointed out. I kinda took liberty and thought that any image in that sidebar needs to work that way. Feel free to change it if you want.

On Aug 19, 2014, at 4:14 PM, Rob Knight notifications@github.com wrote:

Unfortunately, I had partially published a fix for this yesterday, but still needed to account for "bare" images that could be added to the block via the WYSIWYG editor. I took part of your fix and worked it into a24707c

A sample global block is in the department-left-column.hbs file:

I'm not aware of all of the places on the site that have multiple left nav blocks (maybe ITS?), so someone will need to test this.

— Reply to this email directly or view it on GitHub.

jrosczyk commented 10 years ago

Also, please try to assign items that you’re working on to yourself so I know not to do them. I’ve been trying to avoid anything you’ve messaged on just for this reason. Or if that list is too long, feel free to just assign stuff to me and I’ll work off my queue. Thanks :)

On Aug 19, 2014, at 4:18 PM, Jeffrey Rosczyk jrosczyk@ucsc.edu wrote:

I set it up so it would work for all images in the sidebar only, and not just the case that Leslie pointed out. I kinda took liberty and thought that any image in that sidebar needs to work that way. Feel free to change it if you want.

On Aug 19, 2014, at 4:14 PM, Rob Knight notifications@github.com wrote:

Unfortunately, I had partially published a fix for this yesterday, but still needed to account for "bare" images that could be added to the block via the WYSIWYG editor. I took part of your fix and worked it into a24707c

A sample global block is in the department-left-column.hbs file:

I'm not aware of all of the places on the site that have multiple left nav blocks (maybe ITS?), so someone will need to test this.

— Reply to this email directly or view it on GitHub.

knice commented 10 years ago

My bad (again) for stepping on your work. Sorry about that. I'll make sure to assign issues better.

For this issue, because the data definition for the block had specific sizes for two kinds of images, there are two expected behaviors:

  1. A portrait size image that text flows around.
  2. A landscape image that text sits below.

Additionally, if someone just put some text in the WYSIWYG with an image, that needed styles too.

jrosczyk commented 10 years ago

Absolutely no worries. Glad you got it how you wanted ;)

On Aug 19, 2014, at 4:28 PM, Rob Knight notifications@github.com wrote:

My bad (again) for stepping on your work. Sorry about that. I'll make sure to assign issues better.

For this issue, because the data definition for the block had specific sizes for two kinds of images, there are two expected behaviors:

A portrait size image that text flows around. A landscape image that text sits below. Additionally, if someone just put some text in the WYSIWYG with an image, that needed styles too.

— Reply to this email directly or view it on GitHub.

jrosczyk commented 10 years ago

I’m just setting them up for you. Please feel free to change or delete anything you don’t like/need!

On Aug 19, 2014, at 4:31 PM, Jeffrey Rosczyk jrosczyk@ucsc.edu wrote:

Absolutely no worries. Glad you got it how you wanted ;)

On Aug 19, 2014, at 4:28 PM, Rob Knight notifications@github.com wrote:

My bad (again) for stepping on your work. Sorry about that. I'll make sure to assign issues better.

For this issue, because the data definition for the block had specific sizes for two kinds of images, there are two expected behaviors:

A portrait size image that text flows around. A landscape image that text sits below. Additionally, if someone just put some text in the WYSIWYG with an image, that needed styles too.

— Reply to this email directly or view it on GitHub.