search

ucsc / wcms-design-templates

Styles and Javascript for official UC Santa Cruz web templates
http://webassets.ucsc.edu
4 stars 3 forks source link

Left Nav: Left navigation disappears when a faculty category feed doesn't populate #343

Closed teresasilva71 closed 9 years ago

teresasilva71 commented 10 years ago

It used to be that the left nav would stay, now it goes away.

TRUE, the site should have those categories un-indexed so those pages don't appear but they don't always do that.

lals.ucsc.edu legalstudies.ucsc.edu psychology.ucsc.edu

to name a few that I spot checked faculty faculty-no-nav

dajoturner commented 10 years ago

@teresasilva71 Do you have users who have noticed this?

teresasilva71 commented 10 years ago

No, not yet. On Sep 12, 2014 4:22 PM, "David Turner" notifications@github.com wrote:

@teresasilva71 https://github.com/teresasilva71 Do you have users who have noticed this?

— Reply to this email directly or view it on GitHub https://github.com/ucsc/webtemplates2014/issues/343#issuecomment-55472450 .

dajoturner commented 10 years ago

Ok, I'm going to set this to Fix Later.

knice commented 10 years ago

The page loads fine in the WCMS, so this must be an error in the PHP. We had a similar problem with another page: a PHP error caused the page to stop rendering so everything after the PHP was never rendered.

Basically all of the HTML content that is supposed to come after the PHP content isn't loaded because of a PHP error.

I'm assigning this to Tom since that has been his area of expertise on this project.

dajoturner commented 10 years ago

Setting this to Important because of the client impact. @thomasgardner Can you review this issue, and weigh in on what you're seeing?

teresasilva71 commented 10 years ago

Agreed. Important.

knice commented 9 years ago

This occurs because line 757 of wcmsuser/dev/phpapps/directory/directory.php contains the following code:

die("Currently their are no records in the Campus Directory for the listing chosen.");

The die command means PHP stops processing the page entirely. That means the left column and page footer are left out.

Change that line to:

echo "Currently their are no records in the Campus Directory for the listing chosen.";

And the page renders normally again:

screen shot 2014-12-11 at 11 10 44 am

@thomasgardner, can you fix this on prod?

leslieg commented 9 years ago

I wonder if this is also happening for the course feed. The database connection to AIS went down today and I noticed that the left nav disappeared on those pages.

knice commented 9 years ago

I imagine both pages are setup the same way. If the feed is blank, the PHP script terminates and the left column never loads. It should be reconfigured to move on, rather than terminate.

knice commented 9 years ago

This change has been made on dev, so I think it is safe to make it in production. @thomasgardner, can you make this change some time in the next few days? I'd like to close this ticket in the next week.

knice commented 9 years ago

Here is a page you can use to test the change: http://psychology.ucsc.edu/faculty/visiting-scholars.php

I'd make this change myself, but I do not remember how to escalate my privileges so I have permission to edit the appropriate file.

knice commented 9 years ago

@thomasgardner fixed this, because he is awesome. Thank you, Tom!