search

ucscGenomeBrowser / kent

UCSC Genome Browser source tree. Stable branch: "beta".
http://genome.ucsc.edu/
Other
219 stars 89 forks source link

Add error messages for cloud URIs when entering custom tracks. #61

Closed DailyDreaming closed 2 years ago

DailyDreaming commented 2 years ago

Self-explanatory.

christopherLee1 commented 2 years ago

Hey Lon,

Firstly just a comment because I'm a bit confused, but I thought you were working on adding support for these protocols to the gb, is this a stop-gap measure until that is implemented? That's probably best to talk about not on this pull request comments but over email or a zoom meeting.

Secondly, the existing code is pretty confusing but basically lf->fileName in the part you changed is not the url the user just entered in. What the user just entered in is actually held by "line", which is what we are looping over. So you'll want to follow customPpNextReal() into customPpNext() which is where you can add these messages to. Or maybe you had a different use case in mind?

Lastly if you have any questions you feel free to email me directly.

DailyDreaming commented 2 years ago

@christopherLee1 Sounds good. Will shoot you an email on Monday.