search

ucscXena / ucsc-xena-client

Functional genomics browser
Apache License 2.0
57 stars 42 forks source link

Warn IE users #183

Open maryjgoldman opened 7 years ago

maryjgoldman commented 7 years ago

If someone comes to the xenabrowser.net pages, we need to warn them that we don't support IE

pulkitkkr commented 6 years ago

image

I have Fixed this and raised a pull request at https://github.com/ucscXena/ucsc-xena-client/pull/197 , Whenever user opens using IE , it displays the above screen,

pulkitkkr commented 6 years ago

@acthp Any Update? or Wireframe, will fix it accordingly

acthp commented 6 years ago

We'd like this to 1) allow users through, if they insist on using IE, 2) suggest specific browsers, Chrome or FF, 3) link out to https://browser-update.org/update.html, or directly to Chrome and FF, whichever seems best, 4) handle at least /heatmap/ and /transcripts/, and possibly /datapages/ and /hub/. Details below.

1) There is a "notifications" state that will be saved to localStorage, so if the user dismisses a notification, we will not show it on a later session. A notification state is true if the user has dismissed the notification, so it should be displayed when false. The action to dismiss a notification is ['notifications-disable', key]. See js/containers/addHelp.js for an example, which handles displaying notifications 'rowHelp', and 'columnHelp', and issues the appropriate action when dismissed. The HelpBox component is specific to the spreadsheet, and is not appropriate for the IE warning. Rendering directly in Application.js is fine. For this issue, perhaps use key 'warnIE'. The warning should be displayed if the browser is IE, and notifications.warnIE is false.

4) /heatmap/ main component is js/Application.js. /transcripts/ main component is js/transcript_views/TranscriptPage.js. Both should warn on IE. There is, additionally. /datapages/ at js/Datapages.js, and /hub/ at js/hubPagejs, but these are probably not worth instrumenting at this time.

There's always danger that IE will throw an error before getting far enough to render the warning, so it would be good to verify the behavior on a few versions. browserling.com might be useful for that.

naman03malhotra commented 6 years ago

@pulkitkkr are you still working on this issue, or it has been fixed?

maryjgoldman commented 6 years ago

@naman03malhotra We haven't heard anything from @pulkitkkr on this issue.

pulkitkkr commented 6 years ago

@maryjgoldman and @acthp 😁 have done 60-70% workaround for this will raise PR by tomorrow for same , due to some urgent family medical conditions was not able to get connected since past few days but due to his holy grace every thing is under control and shall start with normal working soon

naman03malhotra commented 6 years ago

@pulkitkkr please let me know, if you need any help, especially with UI/UX flow.