ucscXena / ucsc-xena-client

Functional genomics browser
Apache License 2.0
57 stars 42 forks source link

React Dev Tool not working #216

Open sanchitbansal10 opened 6 years ago

sanchitbansal10 commented 6 years ago

React dev toolbar is not showing in Firefox developer edition and neither in chrome

Note: I have previously extensively used it in other projects and its working on the live production site of ucsc-xena

acthp commented 6 years ago

What version of chrome & OS?

We haven't updated react recently, so it's puzzling that it would be different on the production site. Did you install the plugin recently? It's possible they've dropped support for old versions of react. We need to update.

sanchitbansal10 commented 6 years ago

OS --ubuntu 16.04 Chrome --63 (64bit)

Yeah on the chrome i installed it 3 days back.....

acthp commented 6 years ago

Hm. I have react dev tools 3.1.0, which seems to be latest, and it's working. Maybe try restarting the browser. Also, if you click on the icon to the right of the address bar, what status does it report?

sanchitbansal10 commented 6 years ago

I have done restarting..... on the react icon: this page does not appear to be using react react dev tool version : 3.1.0

acthp commented 6 years ago

Perhaps check the plugin via the debugger, as described here:

https://github.com/facebook/react-devtools/blob/master/README.md#debugging-in-chrome

acthp commented 6 years ago

@sanchitbansal10 Can you try the react-update branch, to see if you have the same problem there? Be sure to run npm install to pick up the new dependencies.

This branch updates react to 15.6.2. It hasn't been heavily tested, but is passing unit & integration tests. There are still a bunch of console warnings from the update.

sanchitbansal10 commented 6 years ago

I tried the react-update branch and the problem is still there. I also uninstalled and reinstalled react-dev-tool in chrome...still not solved

Installed another plugin react-detector on chrome...not working with that either

P.S : everything works fine on the live website https://xenabrowser.net/heatmap/

sanchitbansal10 commented 6 years ago

i will check it on another system.

sanchitbansal10 commented 6 years ago

@acthp i saw the application state tree somewhere on the repo....can u direct me to the link

acthp commented 6 years ago

@sanchitbansal10

http://htmlpreview.github.io/?https://github.com/ucscXena/ucsc-xena-client/blob/master/docs/schema.html#Application

This is not up-to-date. I need to review it. The biggest change is separating state by the page, and splitting out the data for the data selection ("wizard") components, because that data is transient.

So, top-level now looks like

{
    spreadsheet: {}
    wizard: {}
    transcripts: {}
}

where the old Application in the schema is split, mostly across spreadsheet and wizard. E.g. columns selected by the user are under spreadsheet, but the list of cohorts currently available on the data hubs is under wizard.