Viz settings: can't turn off normalization

[maryjgoldman]

turning it off doesn't do anything

[albertwchang]

Please assign to me.

[jingchunzhu]

It is not that important to have the custom setting to work as in old code -- the auto setting seems fine and no one complaint.

It is more important to have the normalization be turned off.

[albertwchang]

For the normalization drop-down menu, should the values be Y/N or stay the way they were?

[jingchunzhu]

These are the options under the CHART viewing mode. Under "heatmap" mode, it should also be "none" and one of the others (either "across cohort" or "across selected samples") --- I am not sure which one it is on top of my head.

[albertwchang]

@jingchunzhu If I remember correctly, you had mentioned to only normalize across the chosen samples when this setting was chosen for the heatmaps?

[jingchunzhu]

It is "across selected samples" in the "heatmap" mode

in chart.js, here are the settings. --- note these are not the same state key/parameter (whatever you call it). In chart, the normalization is only applied to the single column. In heatmap, it is applied to the whole dataset. So these are two different parts in the state object (if they are referred to the same state objects, i don't know). But i think the wording and values should be the same.

dropDown = [{ "value": "none", "text": "none", "index": 0 }, //no normalization { "value": "cohort", "text": "across cohort", "index": 1 }, //cohort-level { "value": "subset", "text": "across selected samples", "index": 2 } //selected sample level current heatmap normalization

[albertwchang]

So should we mimick the options from chart.js (have all 3 options), but have the cohort as a non-operating selection in the heatmap section?

[jingchunzhu]

how about just have "none" and "across selected samples" ?

[acthp]

closed via a26d323936d43aa01f105a8c719ac328a69749fb