search

ucscXena / ucsc-xena-client

Functional genomics browser
Apache License 2.0
57 stars 42 forks source link

Increase wizard card height to improve access to done button. #665. #666

Closed frano-m closed 1 year ago

frano-m commented 1 year ago

Closes #665.

acthp commented 1 year ago

Is there a reason to update the initial zoom height when setting the cohort, vs. in initialState.js?

frano-m commented 1 year ago

@acthp are you referring to line 155 'zoom', _.assoc(state.zoom, ['height'], 584)) in js/controllers/common.js?

I think setCohortRelatedFields is called as part of the wizard process. I was trying to match card heights for both wizard and viz mode. In doing this, the canvas size for the wizard card needs to be increased slightly (the viz cards have card title/avatar, and then an additional user interactive card title/subtitle section that the wizard does not have). I then need to reset the canvas height back to the original state value when the wizard mode is completed - via js/controllers/ui.js. Let me know if there is a better way to do this or whether we should just have one height setting (initialState) and not worry about a difference in card heights between wizard and viz mode? I think the difference in viz mode will be an extra ~60px.