search

ucscXena / ucsc-xena-client

Functional genomics browser
Apache License 2.0
57 stars 42 forks source link

KMPlot: Properly handle Data fetching errors when attempting to render Plot graph #8

Open albertwchang opened 8 years ago

albertwchang commented 8 years ago

The "Loading" jumbotron needs to disappear at some point in the event expected group data is unable to be fetched (e.g. down network connection for user, or error returned from backend during Ajax calls).

acthp commented 8 years ago

Not following. It's not rendered after the data arrives. When would it stay up?

albertwchang commented 8 years ago

It disappears after the 'groups' data arrives, but doesn't disappear if the 'groups' data were to not arrive (e.g. the user all of a sudden lost Internet connection before the graph gets rendered).

I believe this issue would be resolved with the solution you had mentioned to me yesterday re: sending actions to reducers to update app state with indicators/flags that would represent issues with AJAX calls, e.g. 401 errors, or the like.

acthp commented 8 years ago

Ah, so we should catch the error & display the error. I don't think a timeout is right thing.

b.c.

On Fri, Feb 19, 2016 at 11:37 AM, Albert Chang notifications@github.com wrote:

It disappears after the 'groups' data arrives, but doesn't disappear if the 'groups' data were to not arrive (e.g. the user all of a sudden lost Internet connection before the graph gets rendered).

— Reply to this email directly or view it on GitHub https://github.com/acthp/ucsc-xena-client/issues/8#issuecomment-186371461 .