search

ucsd-ccbb / qiimp

Web application to collect metadata specifications from an experimenter and produce metadata input files with appropriate constraints
3 stars 7 forks source link

Have sample type default to "other" if that is the only available option. #145

Open shaekin opened 5 years ago

shaekin commented 5 years ago

Under Package Fields>Sample Type, for the host/environments that only have the "other" option available as the sample type (Non-vertebrate animal host, plant host, fungus host, other non-animal host, other EBI-submittable environment), have the "other" option selected by default.

adswafford commented 5 years ago

@shaekin can you post a screen shot of what you're describing or attach an example Qiimp template with this issue? I think that this may not be a bug but may instead be a place to add more instructions/guidance in the help doc if I'm understanding the issue you're reporting. We don't want the users to list the sample_type as other in the template even if they pick other in the wizard since Other is the catch-all for "not covered by the wizard"

adswafford commented 5 years ago

Closing as I'm pretty sure the current behavior is preferred, but reopen and comment if not @shaekin

shaekin commented 5 years ago

It doesn't look like I can reopen it, but here's what I was referring to: image For the file types I mentioned, other is the only option for those sample types. Since it's the only option, it could be helpful to have "other" selected by default. So not a bug, but could be an improvement.

adswafford commented 5 years ago

Got it, that is a small enhancement then, reopening