ucsd-ccbb / qiimp

Web application to collect metadata specifications from an experimenter and produce metadata input files with appropriate constraints
3 stars 7 forks source link

Mouse stool 'env_feature' should be mammalia-associated habitat #173

Open adswafford opened 5 years ago

stephanieorch commented 5 years ago

This is going to be a change in the animal xlsx file. This is why we gave it 3 options: animal, mammal, or livestock-associated habitat.

adswafford commented 5 years ago

I'm a little confused, shouldn't all the mouse templates have mammal instead? Or are you saying that those inherit from a mammalian shared package higher up?

image

Adding @AmandaBirmingham for input too.

stephanieorch commented 5 years ago

yes env_feature is inherited from higher up (from the animal package)

adswafford commented 5 years ago

Gotcha, but it should be specified in the lower package here now for mouse so that mammalian is automatically selected instead of being inherited.

Austin D. Swafford, PhD Director of Research, Center for Microbiome Innovation Jacobs School of Engineering | UC San Diego O: 858-246-2906

Follow @CMIDigest

Subscribe to our mailing list https://signup.e2ma.net/signup/1853757/1802131/

http://ow.ly/kiac30dUAnc http://ow.ly/fXyB30dUAoS http://ow.ly/dKO130dUAuB

PLEASE TAKE NOTICE: The information transmitted is intended only for the person or entity to which it is addressed and may contain information that is confidential, privileged and/or otherwise exempt from disclosure under applicable state and federal law, including, but not limited to, privacy standards imposed pursuant to the Federal Health Insurance Portability and Accountability Act of 1996 (“HIPAA”). Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon this information by persons or entities other than the intended recipient is prohibited. If you receive this transmission in error, please contact the sender immediately and delete the material from any computer. Thank you.

On Tue, Oct 16, 2018 at 8:47 AM stephanieorch notifications@github.com wrote:

yes env_feature is inherited from higher up (from the animal package)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ucsd-ccbb/qiimp/issues/173#issuecomment-430290025, or mute the thread https://github.com/notifications/unsubscribe-auth/AZxBhk_2oJr0kd7ROeK1BKiZPAtjcYzNks5ulf9_gaJpZM4XNqwr .

AmandaBirmingham commented 5 years ago

Do we want to add a mammal level in the hierarchy (below animal) so that you don't have to add mammal as the single choice for env_feature to all three of the mammals separately? Ideally we'd like to minimize duplication ...

adswafford commented 5 years ago

I like that plan!

On Tue, Oct 16, 2018, 10:31 AM Amanda Birmingham notifications@github.com wrote:

Do we want to add a mammal level in the hierarchy (below animal) so that you don't have to add mammal as the single choice for env_feature to all three of the mammals separately? Ideally we'd like to minimize duplication ...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ucsd-ccbb/qiimp/issues/173#issuecomment-430326712, or mute the thread https://github.com/notifications/unsubscribe-auth/AZxBhjFlKP2hM6-m2EoVmxxp2qx3xftzks5ulhffgaJpZM4XNqwr .