DS3-3: Handle blank query on ChatGPT

ucsd-cse110-fa23 / cse-110-project-team-20

cse-110-project-team-20 created by GitHub Classroom

0 stars 0 forks source link

DS3-3: Handle blank query on ChatGPT #216

Closed edykim closed 11 months ago

edykim commented 11 months ago

Added error handling for empty string from Whipser API
Added related test case
Refactored error response method into base class
Adjusted the styling on error page label

https://github.com/ucsd-cse110-fa23/cse-110-project-team-20/assets/33057457/715a9a75-52df-417e-af8e-84e99e5d4e54

Sometimes, Whisper picks up random words from empty voice file spookily. We cannot filter those cases since we are not sure that is actual input or not. This is a example:

close #214

github-actions[bot] commented 11 months ago

Code Coverage

Overall Project	73.65% `-0.33%`	:green_apple:
Files changed	79.49%	:green_apple:

File	Coverage
ServerRecipeGenerator.java	97.49%	:green_apple:
AccountHttpHandler.java	97.25%	:green_apple:
GenerateRecipeHttpHandler.java	83.41% `-6.99%`	:x:
RecipeMarkAsShareHttpHandler.java	76%	:green_apple:
HttpHandlerBase.java	23.77%	:green_apple:

edykim commented 11 months ago

@quantiumtech if there is any meal type input, meal type sanitizer will choose most closest one from breakfast, dinner, lunch. Maybe we should implement other sanitizer that able to catch those invalid input.