ucsd-cse125-sp24 / group5

A character-based ability shooter 2v2 heavily inspired by Four Seasons
https://cse125.ucsd.edu/2024/cse125g5
6 stars 0 forks source link

Audio setup and config setup #20

Closed AnnLe4869 closed 1 month ago

AnnLe4869 commented 1 month ago

I have setup some very basic audio that can play audio and explosion sound periodically and jump sound on keyboard event. Will look into how to do the partial sound I also setup the config such that we can read all config from inside a single json file. like this

std::cout << "My name is " << SetupParser::getValue("name") << std::endl;

right now I put some example setup in the common/setup.json but I image we can do more with this.

Alanine42 commented 1 month ago

thanks for setting up audio and config! this looks good.

I can approve this but looks like some merging is necessary

Alanine42 commented 1 month ago

still need one reviewer who hasn't pushed

@Melody-Ruth @benjxia when ur free

Melody-Ruth commented 1 month ago

It works on my machine! I'll approve it once I understand the cmake changes.

benjxia commented 1 month ago

lgtm