Closed AnnLe4869 closed 1 month ago
thanks for setting up audio and config! this looks good.
I can approve this but looks like some merging is necessary
still need one reviewer who hasn't pushed
@Melody-Ruth @benjxia when ur free
It works on my machine! I'll approve it once I understand the cmake changes.
lgtm
I have setup some very basic audio that can play audio and explosion sound periodically and jump sound on keyboard event. Will look into how to do the partial sound I also setup the config such that we can read all config from inside a single json file. like this
right now I put some example setup in the
common/setup.json
but I image we can do more with this.