ucsd-progsys / liquidhaskell-tutorial

Tutorial for LiquidHaskell
https://ucsd-progsys.github.io/liquidhaskell-tutorial/
MIT License
75 stars 27 forks source link

Review of chapter 1 complete #1

Closed christetreault closed 9 years ago

christetreault commented 9 years ago

I've finished my review of chapter 1, the annotated .pdf can be found at:

https://drive.google.com/file/d/0Bx6BpheCXcBWZzZRQkc4QjByZXM/view

Text in blue are just thoughts I had, nothing particularly critical. Text in red are what I'd consider to be Real Issues.

There wasn't a lot of problems with chapter 1. Random extra apostraphe on page 12, a dead link on page 14, and issues using a solver that isn't z3.

ranjitjhala commented 9 years ago

@christetreault thanks, this is awesome, please keep them coming! I will be going back and updating the chapters per your suggestions...

christetreault commented 9 years ago

All issues either already addressed, or will be addressed by my work-in-progress updates.