ucsd-progsys / liquidhaskell

Liquid Types For Haskell
BSD 3-Clause "New" or "Revised" License
1.18k stars 135 forks source link

Plugin always colors the `**** LIQUID: ` header, regardless of compiler settings #1956

Open Fizzixnerd opened 2 years ago

Fizzixnerd commented 2 years ago

This complicates tools which want to parse the output of the plugin and generate summary data (see #1955 for an example).

src/Language/Haskell/Liquid/UX/CmdLine.hs has a function reportResult that contains this enigmatic comment (see https://github.com/ucsd-progsys/liquidhaskell/blob/develop/src/Language/Haskell/Liquid/UX/CmdLine.hs#L744):

         -- For now, always print the \"header\" with colours, irrespective to the logger
         -- passed as input.
ranjitjhala commented 2 years ago

Hi Matt, we could certainly disable printing the header in “quiet” mode?

On Wed, Mar 30, 2022 at 5:56 AM Matt Walker @.***> wrote:

This complicates tools which want to parse the output of the plugin and generate summary data (see #1955 https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ucsd-2Dprogsys_liquidhaskell_issues_1955&d=DwMCaQ&c=-35OiAkTchMrZOngvJPOeA&r=r3JfTqNkpwIJ1InE9-ChC2ld7xwATxgUx5XHAdA0UnA&m=Fp2sRhhc5g5145qBuNdm1wNoZXOtotq3qWr7RyYvBo7LdsVDCoM679Rfe8yQYUZm&s=S-L9RyA5BFYMrs3ffzUTAGJdmEL06CJ6wReX4RkoR-M&e= for an example).

src/Language/Haskell/Liquid/UX/CmdLine.hs has a function reportResult that contains this enigmatic comment (see https://github.com/ucsd-progsys/liquidhaskell/blob/develop/src/Language/Haskell/Liquid/UX/CmdLine.hs#L744 https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ucsd-2Dprogsys_liquidhaskell_blob_develop_src_Language_Haskell_Liquid_UX_CmdLine.hs-23L744&d=DwMCaQ&c=-35OiAkTchMrZOngvJPOeA&r=r3JfTqNkpwIJ1InE9-ChC2ld7xwATxgUx5XHAdA0UnA&m=Fp2sRhhc5g5145qBuNdm1wNoZXOtotq3qWr7RyYvBo7LdsVDCoM679Rfe8yQYUZm&s=Ct-bwkyum-Ku9z09S1XN9Jjag97qKyDUh8M2nownmSw&e= ):

     -- For now, always print the \"header\" with colours, irrespective to the logger
     -- passed as input.

— Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ucsd-2Dprogsys_liquidhaskell_issues_1956&d=DwMCaQ&c=-35OiAkTchMrZOngvJPOeA&r=r3JfTqNkpwIJ1InE9-ChC2ld7xwATxgUx5XHAdA0UnA&m=Fp2sRhhc5g5145qBuNdm1wNoZXOtotq3qWr7RyYvBo7LdsVDCoM679Rfe8yQYUZm&s=rPol1hEa5zlXjgF7dAeIwQnV5oYWpC0zrJqpCAH2JFQ&e=, or unsubscribe https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAMS4OAAKXEMXMRZ5EJJHULVCRFOHANCNFSM5SB24G3A&d=DwMCaQ&c=-35OiAkTchMrZOngvJPOeA&r=r3JfTqNkpwIJ1InE9-ChC2ld7xwATxgUx5XHAdA0UnA&m=Fp2sRhhc5g5145qBuNdm1wNoZXOtotq3qWr7RyYvBo7LdsVDCoM679Rfe8yQYUZm&s=uBZfIqp4jHBMm_UQ_6LF53ikMrhHuG1PqWYNBlh1oVo&e= . You are receiving this because you are subscribed to this thread.Message ID: @.***>