Update the models for authorities and associate them to Form/UI with hashing. #4 #5 #13

ucsdlib / dams5-cc-pilot

A repository for doing shared R&D on CurationConcerns for the Development team.

MIT License

0 stars 0 forks source link

Update the models for authorities and associate them to Form/UI with hashing. #4 #5 #13 #24

Closed lsitu closed 8 years ago

lsitu commented 8 years ago

https://github.com/ucsdlib/dams5-cc-pilot/issues/4 https://github.com/ucsdlib/dams5-cc-pilot/issues/5 https://github.com/ucsdlib/dams5-cc-pilot/issues/13

lsitu commented 8 years ago

@ucsdlib/developers : Please review and test thank. The bunch of updates are supporting the authority records (Agent, Concept and Place) modeling and associate them to the form/UI for creation, editing and displaying. This will support linking to themselves through an ambiguous URL and linking to collection/object explicitly with hashing. You may access the forms for new authority records creation from the main menu on the top. The change is a little big, please test it to see whether it works at you local environment if you can. Thanks.

VivianChu commented 8 years ago

👍

lsitu commented 8 years ago

@hweng: Are you talking about not using Hydra Editor? Or the app/models/forms/xxx_form.rb file is redundant for Hydra Editor? Here is the official site for Hydra Editor: https://github.com/projecthydra/hydra-editor

hweng commented 8 years ago

@lsitu I didn't say not using hydra Editor. I will take a look of the link when I get time.

mcritchlow commented 8 years ago

@ucsdlib/developers - thanks for the great discussion so far on this. Let me clarify a few points from my perspective, if it helps as you're evaluating.

The scope of this pilot repo is just that, a pilot where we're trying to learn this new stack, how best to use and extend it, and ideally make a determination as to whether CC will fit DAMS5 (so far, so good!)
A major lesson learned from our current hydra app is that we need to do everything we can to ensure that we can upgrade the various gems in the hydra stack going forward. So we should make decisions taking this need into account as well

lsitu commented 8 years ago

@mcritchlow I agree. I think that's one of the reason I discarded my previous PR for sample authority records creation and choose to melt this feature into the hydra stacks instead.

hweng commented 8 years ago

@mcritchlow Thanks for your points. I agree with it. I tested it on Sufia by running its built-in generator which create/insert a number of files which also include xxx_form.rb. And by comparing them to this pull request they are similar. So it is just common way that curation concern based app make up the form. And I understand there must be some reasons that hydra team decides to do this way and I agree with it.

VivianChu commented 8 years ago

@hweng The reason they uses form object mentions here

address gaps in model-view-controller framework: form objects help building editing forms. form wraps the model

https://github.com/projecthydra-labs/hydra-vagrant/wiki/Dive-Into-Curation-Concerns

lsitu commented 8 years ago

@ucsdlib/developers Can you merge the PR if you are convenient? Thanks.

lsitu commented 8 years ago

@ucsdlib/developers: Thanks everyone for reviewing, discussing and testing it out.