search

ucsdlib / dams5-cc-pilot

A repository for doing shared R&D on CurationConcerns for the Development team.
MIT License
0 stars 0 forks source link

Fixes #22 - Update the app to use Collection Membership branch of CC #31

Closed VivianChu closed 8 years ago

VivianChu commented 8 years ago

@ucsdlib/developers - Please review, comment, etc... Thanks

VivianChu commented 8 years ago

@mcritchlow - The code has been updated. Could you review again? Thanks

VivianChu commented 8 years ago

@mcritchlow I tested your one line code and it worked fine. I updated the code to use it.

lsitu commented 8 years ago

@mcritchlow @VivianChu 👍 With so many big changes on going at the CC side, I am wondering whether we should keep it a separate branch for now to avoid any potential issues with keeping CC up-to-date for the collection membership branch. Thoughts?

mcritchlow commented 8 years ago

@lsitu @VivianChu That's a very good point, though this repo is still a pilot and not necessarily slated for production any time soon anyway. It's hard to imagine using a version of CC on our end that doesn't use the collection membership solution in the branch.

That said, I wonder @VivianChu might be able to check in with Esme to see if he knows any more about the future of this branch. Perhaps that might guide our thinking about what to do for now?

VivianChu commented 8 years ago

@mcritchlow @lsitu Sounds good. I will check in with Esme.

lsitu commented 8 years ago

@mcritchlow @VivianChu I am fine to merge it now and update it to the latest CC version once the collection-membership branch is merged to CC.

mcritchlow commented 8 years ago

@lsitu I agree I think that might be the best path. Can we get a Review from someone approving this PR then?