search

ucsdlib / dams5-cc-pilot

A repository for doing shared R&D on CurationConcerns for the Development team.
MIT License
0 stars 0 forks source link

Add A-Z links to facet view pages. (#33) #42

Closed hweng closed 7 years ago

hweng commented 7 years ago

@ucsdlib/developers Please review, comments etc... Thanks.

mcritchlow commented 7 years ago

👍 looks good to me, but will let @lsitu and @VivianChu do the formal review

VivianChu commented 7 years ago

👍

lsitu commented 7 years ago

@hweng I see lots of changes on Gemfile.lock file but can't find anything committed to Gemfile. Do you make any changes to the Gemfile?

hweng commented 7 years ago

@lsitu No, there is no new gem added in this pull request. Have you pulled the latest version from github master branch and run bundle install and do you get error? I got errors which I have to delete the Gemfile.lock and then run bundle install and it get fixed. That's why the Gemfile.lock is changed.

lsitu commented 7 years ago

@hweng It looks like some weird environment but I think it's fine as long as it works. Actually I didn't get any errors with my last PR that is basing on the latest version from github master branch.

hweng commented 7 years ago

Thanks everyone for reviewing and @lsitu for merging.