search

ucsdlib / dams5-cc-pilot

A repository for doing shared R&D on CurationConcerns for the Development team.
MIT License
0 stars 0 forks source link

Latest Blacklight features: alternate search results view(s) #9

Closed mcritchlow closed 7 years ago

mcritchlow commented 8 years ago
hweng commented 7 years ago

@mcritchlow I've set up the blacklight version 6.0. The blacklight itself don't have alternate views, but I found that a gem blacklight-gallery which support for three alternate views: Gallery, Masonry and Slideshow views. I've installed it in blacklight app and it works fine for me in the standalone app. But when I tried to install the blacklight and blacklight-gallary gems to dams5-cc-pilot app, there are some conflicts. Would you like to have a demo of the alternative views from local set up blacklight-demo? Or would you like me to go to the next step to implement the blacklight-gallary to our dams5 app?

mcritchlow commented 7 years ago

per discussion with @hweng. For this Sprint it would be nice to have a demo of the working alternate search result views either via the blacklight app or the dams5-cc-pilot app. If it can be integrated, that would be ideal, if not starting to identify the series of steps to get it integrated with a Curation Concerns app will be of value to us since we will definitely be using this plugin in our eventual dams5 production app.

mcritchlow commented 7 years ago

@hweng - I think, per your demo and the code being committed, this can be closed. Is that correct?

hweng commented 7 years ago

@mcritchlow, yes the overall function works fine to me. I think this ticket can be closed. For the detail CSS fix or update, it can be created in separate ticket when need.

mcritchlow commented 7 years ago

Great, please go ahead and close then.

hweng commented 7 years ago

@mcritchlow This new feature has been in feature branch. I've submitted a pull request for it and after it is merged into master, I will close this ticket.

lsitu commented 7 years ago

@hweng: I see two commits. It look like your older commit wasn't replaced correctly. Maybe you can do a rebase to remove the older (commit)[https://github.com/ucsdlib/dams5-cc-pilot/commit/79aebe135d3094a5385b2e1987fe25bb4f62f242]? Otherwise 👍

hweng commented 7 years ago

@lsitu There is actually only one commit in the pull request, would you check the pull request: https://github.com/ucsdlib/dams5-cc-pilot/pull/26

lsitu commented 7 years ago

@hweng Okay, got it. Just something strange here.

hweng commented 7 years ago

@lsitu Yeah, I think what showed here just the action history?

lsitu commented 7 years ago

Yes, different display from Jira that caught my attention.