ucsdlib / damsmanager

DAMS Manager
Other
3 stars 1 forks source link

Improve output of the DAMS Collection Status Report #351

Closed gamontoya closed 5 years ago

gamontoya commented 5 years ago

Descriptive summary

Determine best way to accurately report a recently release/added collection. A collection should only report itself as new once only.

Rationale

Sometimes a collection is listed as newly released when it was released months ago.

Per Longshou:

So collection bb1745304h should be just release to public last month. But it looks like it was release at 2019-06-05T10:31:48+0000 as well. So maybe someone performing a reverse release? Collections with new object added should show up in group Collections with objects added. The Collection Release group will show those collections that were release June 1 - June 30 . Since collection has a release bb1745304h timestamp 2019-06-14T08:21:54+0000, it will show up in the group Collection Release. The event shows Greg run the release at that time. Maybe we can open a ticket so that we can inspect the results and make the rule change for it when needed.

Expected behavior

Collections should only show up in a report once for a given month.

release

In the above example, 4 of the 5 listed new collections are not new. They were released months ago so something is triggering them to be listed again as new.

lsitu commented 5 years ago

@mcritchlow I've added PR https://github.com/ucsdlib/damsmanager/pull/352 that will prevent those collections that were released in the past from adding the record released event again so that it won't be reported more than once.

lsitu commented 5 years ago

@gamontoya The PR https://github.com/ucsdlib/damsmanager/pull/352 won't fix the current collection status report but it will prevent new released collections from reporting more than once in the feature. Does it sounds good?

gamontoya commented 5 years ago

@lsitu Yes, sounds great!