search

ucsdlib / damsmanager

DAMS Manager
Other
3 stars 1 forks source link

Apply a conditional placement (RDC/non-RDC) for Note:Preferred Citation #368

Closed hjsyoo closed 5 years ago

hjsyoo commented 5 years ago

Descriptive summary

Note: this ticket was re-specified on 2019-10-23 to capture the discussion at the DAMS Working Group meeting on 2019-10-15.

When re-ordering DAMS elements as indicated in https://github.com/ucsdlib/damspas/issues/632, apply a conditional placement for Note:Preferred Citation.

Rationale

This work is needed concurrent with re-ordering DAMS elements: https://github.com/ucsdlib/damspas/issues/632. The goal is to allow citations for RDC objects to be displayed in a different relative position than it is for non-RDC objects.

Related work

https://github.com/ucsdlib/damspas/issues/632 https://github.com/ucsdlib/damspas/pull/720#

gamontoya commented 5 years ago

Hi @VivianChu. This ticket is waiting for input from @arwenhutt

arwenhutt commented 5 years ago

@gamontoya I think this does need DAMS metadata policy group discussion -- I'd also like to discuss with @ucsdlib/domm the property name.

hjsyoo commented 5 years ago

That sounds fine, although I wonder if the working group might also be appropriate? The key request here is for a way for RDC and non-RDC objects to have different rank placement for the Preferred Citation field. We aren't tied to a particular strategy for accomplishing this.

arwenhutt commented 5 years ago

@jessicahilt @gamontoya @hjsyoo Yeah, if the ticket is really a request for:

RDC and non-RDC objects to have different rank placement for the Preferred Citation field

then developer feedback / working group discussion makes sense.

The solution in this ticket is definitely workable, but there might be beter options.
E.g. Like context specific rendering, e.g. if an object is in the rdcp unit, then display the elements in a different order. I have no idea if that would be even doable, or whether it would be better or worse, than adding a new property to the data model and all of the damsmanager tools.

For the new property solution, I think the main costs are:

From a DOMM perspective, I think these are fine - though we still would need to have some discussion about the property details and do the DMPS vetting.

gamontoya commented 5 years ago

Per Matt, put a conditional on the code.

gamontoya commented 5 years ago

@VivianChu See above. If there are issues, please discuss with Matt.

VivianChu commented 5 years ago

@gamontoya - It's fine to use a conditional on the code. I just want to confirm the change. For rdc object, the preferred citation note will be displayed as "Cite This Work" above Note:Description element. For non-rdc object, then it will be displayed as "Preferred Citation" above the Copyright element. Is that correct? Thanks

hjsyoo commented 5 years ago

@mdpeters @cgarciaspitz Do you want to keep the "Cite This Work" label on Note:Preferred Citation? I don't think we discussed changing this, so want to confirm that the label should remain as is for non-RDC objects?

mdpeters commented 5 years ago

@hjsyoo "Cite This Work" label is fine by me.