ucsdlib / damsmanager

DAMS Manager
Other
3 stars 1 forks source link

Event metadata missing from object records #392

Closed arwenhutt closed 4 years ago

arwenhutt commented 4 years ago

Descriptive summary

Some object records are missing event metadata.

Examples:

These records have only one event at the object level, of type "record edited" They should have at least two events, "record created" and "record edited," and possibly more depending on the records event history.

lsitu commented 4 years ago

@mcritchlow I've added MR https://github.com/ucsdlib/damsmanager/pull/397 to retain the events metadata. It's ready for review now. Thanks.

arwenhutt commented 4 years ago

@lsitu Can you give us some information about why event data was missing, and what conditions causedit? also when the relevant code was deployed?

This will help us with figuring out how to test and give us an idea for how many records may have been affected.

lsitu commented 4 years ago

@arwenhutt I think the major reason is that we failed to pass the curator name over to the backend damsrepo, and damsrepo just use an empty ark to create the event for the user. The codes are deployed to staging and I think you can test it now:

  1. Ingest some new objects and validate events.
  2. Batch overlay the objects and validate all events again.
  3. Test RDF Import and validate events ...
arwenhutt commented 4 years ago

@lsitu does that mean it's related to https://github.com/ucsdlib/damsmanager/issues/393 ?

lsitu commented 4 years ago

@arwenhutt Yes. The tests are related and this will test both tickets. My comment above is actually more related to #393. The missing events here is that the even metadata will be erased together while erasing other metadata.

arwenhutt commented 4 years ago

@lsitu I tested ingest, batch overlay (3 times) for batch of objects (test ah1) + single item edit for 1 of the items. I've reviewed the events for the single item carefully and they look correct (number, type) - also reviewed a sample of items from the rest of the batch and they look good.

arwenhutt commented 4 years ago

@lsitu verified on production ✔️