Report errors on each Roger records for MARC Import tool

lsitu commented 4 years ago

References #390

Local Checklist

[x] Tests written and passing locally?
[x] Code style checked?
[x] QA-ed locally?
[x] Rebased with master branch?
[ ] Configuration updated (if needed)?
[ ] Documentation updated (if needed)?

What does this PR do?

Report errors on Roger records for MARC Import tool

Why are we doing this? Any context of related work?

References #390

Where should a reviewer start?

Manual testing steps?

Screenshots

Screenshots for error report instead of null:

Database changes

New ENV variables

References #issuenumber

Deployment Instructions

@mcritchlow @ucsdlib/developers - please review

lsitu commented 4 years ago

@mcritchlow I've renamed the method testConversion to testRogerRecordConversuon. Just let me know if you want to put the line File tmpFile = File.createTempFile("bib", "-rdf.xml"); with createTempFile in a synchronized block.

mcritchlow commented 4 years ago

@lsitu - That sounds great. As for the synchronized block, I suppose I defer to you. I'm not sure if the code will be run in a context where that might become an issue. If you think it won't. Then I think this PR should go in as-is.

lsitu commented 4 years ago

@mcritchlow I just double check that we use the method File.createTempFile for derivative creation in the past and so far we haven't run into any troubles with it. Maybe just leave it as-is for now? Thanks.

ucsdlib / damsmanager