search

ucsdlib / damsmanager

DAMS Manager
Other
3 stars 1 forks source link

empty dams:copyright property created on ingest #402

Closed arwenhutt closed 4 years ago

arwenhutt commented 4 years ago

Descriptive summary

We've found many examples of objects with an empty dams:copyright property <dams:copyright><dams:Copyright /></dams:copyright>

in some cases this is the only copyright info in the record, sometimes it is in addition to a populated copyright property.

This was identified during testing of release candidate 2.77 on staging, but also is seen in production objects ingested with previous releases.

This seems to also be affecting display, with objects sometimes not displaying copyright info (use, status, constraints on use) in the UI. It seems that:

Example:

This collection of objects was ingested at the end of last week. On nothing the issues, we exported the metadata:

*note that the items were subsequently edited so the collection could be reviewed by data providers, and so the records in the dams have been manually cleaned up and the empty properties removed. The exports attached were made before any editing and show the records as they were created on ingest.

lsitu commented 4 years ago

@arwenhutt I see column Copyright status and Copyright holder are there in the ingest metadata, which may cause the confusing. At this time, the batch editing/overlay tool expects the copyrights to be captured from the spreadsheet while the batch ingest expect it from the Excel InputStream form, which causing the trouble. Would you like me to just ignore all fields related to copyright and Copyright holder for new object ingest now?

arwenhutt commented 4 years ago

@lsitu ah! I totally missed that. I just looked at some objects with the blank copyright that had been ingested into production and their spreadsheets have the same columns.

hmmm, since the batch overlay can import those fields, how difficult would it be to have the excel input stream work the same way - use information from the spreadsheet instead of the form?

lsitu commented 4 years ago

@arwenhutt It won't be hard but if we want to move forward with the deployment now, I think we can simply fix the empty copyright element issue now and then made the improvement for ticket Move rights and access controls into spreadsheet in the next step, which may need some discussions. Or would you like to hold on the new release and wrap up the ticket now?

arwenhutt commented 4 years ago

@lsitu I think the only reason we might consider holding the new release is if the interim fix was a lot of work or would make it a lot harder to move rights into the spreadsheet in the future.

But it sounds like it probably isn't and doesn't, so...

ignore all fields related to copyright and Copyright holder for new object ingest

sounds like the best plan!

lsitu commented 4 years ago

@arwenhutt Yes, it's a simple fix.

arwenhutt commented 4 years ago

@lsitu great!

lsitu commented 4 years ago

@arwenhutt @mcritchlow I've added PR https://github.com/ucsdlib/damsmanager/pull/403 to fix the empty copyright element problem. It's ready for review now. Thanks.

lsitu commented 4 years ago

@arwenhutt The changes in PR https://github.com/ucsdlib/damsmanager/pull/403 to staging is deployed to staging, which will fix the empty Copyright element in Excel InputStream. Could you test it on staging? Thank you.

arwenhutt commented 4 years ago

@lsitu this looks good! I checked all the values we use in those fields and none of the records created have an empty copyright element.

arwenhutt commented 4 years ago

reopening for production verification

arwenhutt commented 4 years ago

@lsitu verified on production ✔️