Fixes - #93 Upgrade hyrax.

ucsdlib / damspas-rd

A Digital Collections application based on Hyrax

MIT License

3 stars 2 forks source link

Fixes - #93 Upgrade hyrax. #109

Closed hweng closed 7 years ago

hweng commented 7 years ago

Fixes #93

Upgraded hyrax to the point: https://github.com/projecthydra-labs/hyrax/commit/562b8ffab8f1770a45a7b231c1e573dc0d2455cf
Fixed failed test.

@ucsdlib/developers - please review

lsitu commented 7 years ago

@hweng Those minor changes could be the reason of some historical issues. As long as the rspec test suites pass, then I think it'll be safe to delete the controller.rb file.

hweng commented 7 years ago

@lsitu The test would pass if delete controller.rb. Just let you aware that there are some methods in local controller.rb but not in hyrax/controller.rb, For example: https://github.com/ucsdlib/horton/blob/develop/app/controllers/hyrax/controller.rb#L16

It would be fine to me to delete it if all of you agree.

lsitu commented 7 years ago

@hweng I see that, which could be migrated from CC pilot version in the past. Please feel free to delete the whole file since the rspec test passed.

hweng commented 7 years ago

@lsitu The controller.rb is removed.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 91.846% when pulling d4fb119906083e006db5a23cdbaeb55671e1b3d4 on feature/upgrade_hyrax into eed6e861bd8d0a190a87c6c24151667e9d21bb55 on develop.

lsitu commented 7 years ago

👍

VivianChu commented 7 years ago

👍