search

ucsdlib / damspas-rd

A Digital Collections application based on Hyrax
MIT License
3 stars 2 forks source link

Updated configuration for rubocop and auto corrected violations. #117

Closed lsitu closed 7 years ago

lsitu commented 7 years ago

Updated configuration for rubocop to make it inline with hyrax and auto corrected violations.

Added a commit with rubocop auto fixes so that we can see more straight forward regarding what kind of style check violations that we need to fix, which will fix those violations like indentations, spacing etc, empty lines. Also, following the the original configuration, spec checks are excluded at this time.

@ucsdlib/developers - please review

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 92.05% when pulling 55b5b7d3c2d42471e6ab7c5d6f64c78d06de8a22 on feature/config_rubocop into 90b7ef132c49e596a52b8471b4d7cc7b914cb08b on develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.07%) to 92.192% when pulling f584cd5aef3013803003532958fb0a96504fb4bc on feature/config_rubocop into 90b7ef132c49e596a52b8471b4d7cc7b914cb08b on develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.07%) to 92.192% when pulling 6d55fd86a242da678bf338d711691e446716dd6c on feature/config_rubocop into 90b7ef132c49e596a52b8471b4d7cc7b914cb08b on develop.

lsitu commented 7 years ago

@ucsdlib/developers I think I've got all those rubocop style issues addressed. However hound still reported 2 violations without sending out any messages, which are hard to figure out what's going on. Could you review and comment? Please check it out and make surerubocop pass in your local environment for future development. Thanks.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.07%) to 92.192% when pulling 00468433de1fa66df04a0e12e1190befee517e9f on feature/config_rubocop into 90b7ef132c49e596a52b8471b4d7cc7b914cb08b on develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 92.097% when pulling c6cf8d3efd57976de27fc7569e86519583bd2ed1 on feature/config_rubocop into 90b7ef132c49e596a52b8471b4d7cc7b914cb08b on develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.07%) to 92.192% when pulling c6cf8d3efd57976de27fc7569e86519583bd2ed1 on feature/config_rubocop into 90b7ef132c49e596a52b8471b4d7cc7b914cb08b on develop.

lsitu commented 7 years ago

@mcritchlow Agree. We should try our best to address those style check issues in the to do list when we touch those files later, though some of them are not easy to fix.

VivianChu commented 7 years ago

👍