ucsdlib / damspas-rd

A Digital Collections application based on Hyrax
MIT License
3 stars 2 forks source link

Feature/remove local pages #118

Closed VivianChu closed 7 years ago

VivianChu commented 7 years ago

Fixes #89 ; refs #89

Remove local Pages implementation and create entries in the routes file for our existing static pages.

@ucsdlib/developers - please review

mcritchlow commented 7 years ago

LGTM, but will need rebase once #117 gets merged

mcritchlow commented 7 years ago

@VivianChu - Ok, Longshou's PR is merged. Looks like a handful of pages need updating via a rebase, as expected.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.5%) to 91.768% when pulling 52c2653592799d0ff031f8c6d93f2b11e5e573be on feature/remove_local_pages into 90b7ef132c49e596a52b8471b4d7cc7b914cb08b on develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 91.956% when pulling a51df8c18ef9879ac8eb14d9e852b876e8a6bbae on feature/remove_local_pages into 90b7ef132c49e596a52b8471b4d7cc7b914cb08b on develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 91.956% when pulling c0b025100acdc2371aba0685f87086c6770ffc59 on feature/remove_local_pages into 90b7ef132c49e596a52b8471b4d7cc7b914cb08b on develop.

VivianChu commented 7 years ago

@ucsdlib/developers - This branch has been rebased with the develop branch. Please review, comment, etc... Thanks

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 91.956% when pulling fdd3f072ca07a4f976f5ab78c66bc873421d4d62 on feature/remove_local_pages into b6f57990faf6074ad308ba0566bea61303a909a6 on develop.

lsitu commented 7 years ago

@VivianChu It looks good 👍 . Just a minor question regarding the related db migration files for pages.

lsitu commented 7 years ago

👍

hweng commented 7 years ago

:+1:

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 91.956% when pulling ce4baf4194bbb6825581a3c0d877d2f580117862 on feature/remove_local_pages into b6f57990faf6074ad308ba0566bea61303a909a6 on develop.