ucsdlib / damspas-rd

A Digital Collections application based on Hyrax
MIT License
3 stars 2 forks source link

Fixes #122 - Upgraded hyrax to the latest commit on master branch. #123

Closed lsitu closed 7 years ago

lsitu commented 7 years ago

Fixes #122 ; refs #122

Upgraded hyrax to the latest commit on master branch.

Changes proposed in this pull request:

@ucsdlib/developers - please review

mcritchlow commented 7 years ago

Ah, that makes much more sense. Thanks for the pointer!

On Fri, Jul 14, 2017, 3:06 PM lsitu notifications@github.com wrote:

@lsitu commented on this pull request.

In app/controllers/hyrax/collections_controller.rb https://github.com/ucsdlib/horton/pull/123#discussion_r127557892:

@@ -2,6 +2,8 @@ module Hyrax class CollectionsController < ApplicationController include Hyrax::CollectionsControllerBehavior include Hyrax::BreadcrumbsForCollections

  • layout :decide_layout
  • load_and_authorize_resource except: [:index, :show, :create], instance_name: :collection

@mcritchlow https://github.com/mcritchlow: Good question! I think action :create is expected to have its's own authorization before creating a new collection, see collections_controller_behavior.rb#L103 https://github.com/samvera/hyrax/blob/master/app/controllers/concerns/hyrax/collections_controller_behavior.rb#L103 .

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/ucsdlib/horton/pull/123#discussion_r127557892, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEHsuGD_JIlToWQ5j01oRj4yFFLOwQQks5sN-ZfgaJpZM4OYvoU .

VivianChu commented 7 years ago

👍