ucsdlib / damspas-rd

A Digital Collections application based on Hyrax
MIT License
3 stars 2 forks source link

Fixes #143 - Upgraded to Hyrax 2.0 beta4 #146

Closed hweng closed 6 years ago

hweng commented 6 years ago

Fixes #143 ; refs #143

A list of changes:

@ucsdlib/developers - please review

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.7%) to 89.808% when pulling c783114fbc25a5660342db6f15df7ad0a3a66ee4 on feature/upgrade_hyrax into d8693a3c1ff4848b3f7318a725dafa15b2a0ca55 on develop.

lsitu commented 6 years ago

👍. Just the same concerns regarding the additional boilerplate files as @mcritchlow noted.

VivianChu commented 6 years ago

👍 looks good to me. I just have the same concerns as @mcritchlow & @lsitu

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 90.51% when pulling 4fc81cd902a7411de4866bed5da535b39f6b7f49 on feature/upgrade_hyrax into d8693a3c1ff4848b3f7318a725dafa15b2a0ca55 on develop.

hweng commented 6 years ago

@ucsdlib/developers - It was removed. please review.

lsitu commented 6 years ago

@mcritchlow @VivianChu Either remove those boilerplate files for now or refactoring codes to use them will be fine with me. What do you think?

VivianChu commented 6 years ago

Either way is fine with me.